Remove unused requirement for importlib-metadata #1807
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
This comment was marked as outdated.
This comment was marked as outdated.
@akx please be careful, there were new lines at the end of your comment. The bot is very simple and will not handle whitespaces correctly. Please post a new comment with exactly what it expects. |
|
I have read the CLA Document and I hereby sign the CLA |
akx
force-pushed
the
remove-outdated-importlib-metadata-dep
branch
from
7cfde75
to
cebc433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
None. It just removes a requirement that can't possibly be used since it'd only be used for Python < 3.8, but the library itself requires Python >= 3.8.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
It removes the unnecessary requirement line.